Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving {% block importmap %} *above* {% block javascripts %} #1288

Closed
wants to merge 1 commit into from
Closed

Moving {% block importmap %} *above* {% block javascripts %} #1288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion symfony/asset-mapper/6.4/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in symfony/asset-mapper/6.4/manifest.json

View workflow job for this annotation

GitHub Actions / call-qa / Run checks 

"add-lines" (index 0) must have a "position" key with one of the following values: "top", "bottom", "after_target"
"copy-from-recipe": {
"assets/": "assets/",
"config/": "%CONFIG_DIR%/",
Expand All @@ -16,7 +16,7 @@
{
"file": "templates/base.html.twig",
"content": "{% block importmap %}{{ importmap('app') }}{% endblock %}",
"position": "after_target",
"position": "before_target",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting situation :). But (see error above), there is no before_target - there just wasn't a need for it. Either we need to think of some other solution or add that to Flex.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I opened #1289 to add the block's name to {% endblock %}. Then it would be easily possible to move {% block importmap %} below that (i.e. after_target {% endblock javascripts %} ) - at least for future users...
(If order doesn't matter - which I don't know)

"target": "{% block javascripts %}",
"warn_if_missing": true
}
Expand Down
Loading