Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Keep me logged in as a translatable message #1498

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

llupa
Copy link
Contributor

@llupa llupa commented Feb 18, 2024

I used Wikipedia's login page for all messages.

Some notes:

  • Wikipedia only has pt and this app has pt_BR. Generally Wikipedia's login labels are different from the demo, but I cannot really tell the cultural difference of Keep me logged in
  • I could not find a way to trigger Wikipedia's sr for latin script, it always defaulted to cyrilic. I used Google's translate API to get the latin version. (It looks ok, but slavic languages are not my forte).
  • The demo app renders the Japanese text correctly in browser, but over GH it is just a square (test: ロ).

@llupa llupa marked this pull request as ready for review February 18, 2024 14:22
@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 19, 2024

@llupa thanks a lot for taking the time to extract this new translation. I know this takes some time, so we truly appreciate it 🙇

In #1495 we added a Bengali translation (code bn). The "Keep me logged in" string should be translated as আমাকে প্রবেশকৃত অবস্থায় রাখুন. If you have some time for this, please add that translation too. Otherwise, I'll do it while merging. Thanks a lot!

@llupa
Copy link
Contributor Author

llupa commented Feb 19, 2024

@javiereguiluz done 👍 but I used GH UI sync button and it did it via merge, not rebase. IDK if you squash when accepting PRs or not. but I can also squash from my side.

Let me know.

@javiereguiluz
Copy link
Member

Thanks a lot. Yes, the tool we use to merge things squashes everything by default. If it doesn't work in this case, I'll tell you. Thanks.

@gmsantos
Copy link
Contributor

Wikipedia only has pt and this app has pt_BR. Generally Wikipedia's login labels are different from the demo, but I cannot really tell the cultural difference of Keep me logged in

Native pt-br speaker here. Current translation is fine 👍

@javiereguiluz
Copy link
Member

This is now merged! Thanks a lot @llupa

@javiereguiluz javiereguiluz merged commit af72ef2 into symfony:main Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants