Remove extension test #668
Conversation
|
@pjreed how hard would it be to make the CI also build this in ARM64? |
|
I've looked into it a little bit, and I don't think it'd be too hard to make the ROS Industrial scripts also run in an ARM64 image. I'll experiment with it. |
|
Ok, I think I've gotten the CI to build on ARM64 with both Kinetic and Melodic. Try cherry-picking this into your branch: https://github.com/pjreed/mapviz/tree/add-arm64-ci |
|
Drat, job timed out. This should also be running in the PR tester on the ROS build farm, though, so I'm going to experiment and figure why that's not showing up here... |
|
The mapviz config in the rosdistro repository was pointed at the After that, the official ROS build farm will start building PRs... although it seems like it always builds them for amd64 rather than ARM, so that might not help us. |
|
I added another commit to my branch that should work much better; it will make the builds run in native ARM64 build environments instead of qemu. Give that a try. |
…remove-extension-test
|
@danthony06 were you building on 18.04? Seems like the CI arm build fails in the exact same way on that but works on kinetic. |
|
It was 18.04.
…On Tue, Jan 21, 2020, 9:54 AM Matthew ***@***.***> wrote:
@danthony06 <https://github.com/danthony06> were you building on 18.04?
Seems like the CI arm build fails in the exact same way on that but works
on kinetic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#668?email_source=notifications&email_token=ABBZWHCC4RQXIHH5SWICIADQ64LCJA5CNFSM4KI5S242YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQHNCY#issuecomment-576747147>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBZWHEVCZ3DGMVJY3AYWE3Q64LCJANCNFSM4KI5S24Q>
.
|
|
The ROS build farm also succeeds on 16.04 but fails on 18.04, so that seems right: |
|
Nice, build looks good. |
|
It looks like the build is now broken on AMD64 platforms: http://build.ros.org/job/Kpr__mapviz__ubuntu_xenial_amd64/9/console |
|
Should be fixed now |
|
Guess just needs to be tested on AMD64 to make sure I didnt break the screenshot acceleration |
|
Looks like it's not working on a real display. When I try to add a point cloud or image, I get the following error on the command line, and mapviz appears to hang. (mapviz:7969): GLib-GObject-WARNING **: 15:18:14.497: cannot register existing type 'GtkStyle'
(mapviz:7969): GLib-GObject-WARNING **: 15:18:14.497: cannot add private field to invalid (non-instantiatable) type '<invalid>'
(mapviz:7969): GLib-CRITICAL **: 15:18:14.497: g_once_init_leave: assertion 'result != 0' failed
(mapviz:7969): Gtk-CRITICAL **: 15:18:14.497: gtk_paint_vline: assertion 'GTK_IS_STYLE (style)' failed |
Not ready yet, just want to be able to run the CI.
Theoretically this fixes the ARM64 builds, or at least the OpenGL issue with them.