Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ng-content at the end of the svg to allow users to add custom svg elements over the nodes. #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kr0san89
Copy link
Contributor

As SVG Renders in Order as provided in the DOM with the current approach we can only add elements in the background but this ng-content allows with the class "end-content" to brings them into the foreground

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Custom SVG Elements only in Background

What is the new behavior?
Custom SVG Elements in Background and Foreground

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
If someone used already the css class "end-content" the svg elements would go into foreground, but i guess this is unlikely

Other information:

…om svg elements over the nodes.

As SVG Renders in Order as provided in the DOM with the current approach we can only add elements in the background but this ng-content allows with the class "end-content" to brings them into the foreground
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant