Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize generated gemspec with current bundler template #12414

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

segiddins
Copy link

@segiddins segiddins commented Jun 26, 2024

See template at https://github.com/rubygems/rubygems/blob/d786a1ccca3922d21572f77b021c51bfaf005819/bundler/lib/bundler/templates/newgem/newgem.gemspec.tt#L34

Additionally, exclude .gem files, since there seem to be several gems built from swagger-codegen that are recursively including older .gem versions, and thus growing in size exponentially

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@segiddins
Copy link
Author

cc @zlx

@segiddins
Copy link
Author

@zlx ping

See template at https://github.com/rubygems/rubygems/blob/d786a1ccca3922d21572f77b021c51bfaf005819/bundler/lib/bundler/templates/newgem/newgem.gemspec.tt#L34

Additionally, exclude .gem files, since there seem to be several gems built from swagger-codegen that are recursively including older .gem versions, and thus growing in size exponentially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant