Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add radiofrance logo #9043

Open
wants to merge 2 commits into
base: svelte-4
Choose a base branch
from

Conversation

bleucitron
Copy link
Contributor

We are using Svelte/Sveltekit at Radiofrance, and we love it !

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: fb7bba1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

Please run the SVG through svgo, or set the PR so that Svelte maintainers can push to it so I can do it (might not be possible since this PR was opened from an org's fork rather than your own fork).

@bleucitron
Copy link
Contributor Author

Okay, i hope it's fine now.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not look very good to me

Screenshot from 2023-07-26 15-10-35

@bleucitron
Copy link
Contributor Author

I tried playing with the --row-size and widths of a and .spacer, but nothing really shined (i didn't really like having the names perfectly aligned).

Maybe it's okay to limit the number of names to 14, but randomize the ones actually displayed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants