-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: define role="application"
as an interactive ARIA role
#8975
base: svelte-4
Are you sure you want to change the base?
fix: define role="application"
as an interactive ARIA role
#8975
Conversation
role="application"
as an interactive rolerole="application"
as an interactive ARIA role
@geoffrich can you have a look? I've read the spec and it sounds like |
Hm, reading the spec I'm not sure that
It contains interactive elements but I'm not sure it's able to be interacted with directly. But I have to admit this is a role I haven't used before One worry I have with merging this PR is that it would encourage people to start throwing the But I think the fact that these warnings are telling people to throw ARIA roles on everything without fully understanding the implications points at a larger issue that may require some thought on how to provide better guidance and reduce false positives (see also #8964, #8273, #8001). I'm unfortunately pretty busy prepping for a conference talk at the end of the month, but that's something I want to take a closer look at when I have more time. |
Thanks guys, appreciate the caution on the review, and no rush - it's just a build warning 🙂 When I read the spec, "An ...I also wouldn't be the only misinterpreting: dequelabs/axe-core#890 @geoffrich - The blogpost that you linked was written in 2012 with reference to concerns with the ARIA 1.0 spec. Previously the The
@dummdidumm - I'm not sure If we are worried about people "throwing the |
I raised the query in w3c/aria#1985 |
Interactive elements that are not described by existing ARIA widget roles should have
role="application"
, and should resolve warning no-interactive-element-to-noninteractive-roleFor example, the
Cropper
component from Svelte Easy Crop does match any of the other ARIA widget role descriptions.See spec: https://www.w3.org/TR/wai-aria-1.1/#application
Fixes #8943