add: import decoded sourcemaps from SourceMapGenerator

[milahu]

fix #5722 in a performant way

[benmccann]

this looks pretty good to me. thanks for the fix!

[milahu]

avoided commit-squash to reduce diffs .. i assume maintainers can sqash commits?

[Conduitry]

How much of this code is taken from another project? Can we update this to follow Svelte's snake case naming conventions? Do we think there are likely to be upstream changes we want to manually pull in, and would using different variables make that more difficult?

[milahu]

Can we update this to follow Svelte's snake case naming conventions?

sure. only thing we must keep are the property names, like originalLine, originalColumn

which one is less horrible?
decodedSourcemap_from_SourceMapGenerator
decoded_sourcemap_from_source_map_generator
dsmap_from_smgen

DecodedSourcemap and SourceMapGenerator are types

upstream changes

very unlikely, last release 3 years ago = abandoned

[benmccann]

decodedSourcemap_from_SourceMapGenerator

let's not mix cases 😄 (though I understand the reason it was proposed)

decoded_sourcemap_from_source_map_generator

this is the best of the proposed options in my opinion. though strange that it has both sourcemap and source_map in the name

dsmap_from_smgen

I would have no idea how to read this

Can I propose a new option of decoded_from_generator? I think that it's clear we're working with sourcemaps here, so could drop that from the name for brevity. If there were any doubt we could add a jsdoc to say something like "Decodes a source map from source map generator"

[milahu]

dsmap_from_smgen

I would have no idea how to read this

dee-ess-mapp-from-ess-emm-genn .... easy ; )

I think that it's clear we're working with sourcemaps here

sourcemaps and strings ..

what about decoded_sourcemap_from_generator?

[benmccann]

decoded_sourcemap_from_generator sounds good to me

[benmccann]

I think Conduitry was also asking if we could rename all the other variables and functions to use snake_case rather than camelCase

[milahu]

good fight, good night
https://images-cdn.9gag.com/photo/a4ZXnVZ_700b.jpg

[benmccann]

I'm not quite sure how to interpret. I guess you are going to bed. Will you rename the variables later?

[Conduitry]

I've pushed a commit to rename these and to also do some other tidying up and inlining of functions that are just called once. I'm aiming to merge this today and take a look for anything else screaming to be merged and then cut a release. Although this is technically a new feature, I'm thinking of still releasing this as a patch release.

[benmccann]

lgtm. thanks for the quick fix! really excited about this new feature!