chore: refactor set_attributes
code generation
#13353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the refactoring stuff out of #13338. It doesn't change any behaviour, it just dries the code out — at present there's a ton of duplication between
RegularElement
with aSpreadAttribute
, andSvelteElement
(which always usesset_attributes
because we need to be conservative about custom elements).The next step will be to generate code differently so as to fix #13270, but merging this first will reduce the noise of that work substantially. I'll self-merge this once green, since it's just moving some code around, so that I can continue working on that.