Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor set_attributes code generation #13353

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

Rich-Harris
Copy link
Member

This extracts the refactoring stuff out of #13338. It doesn't change any behaviour, it just dries the code out — at present there's a ton of duplication between RegularElement with a SpreadAttribute, and SvelteElement (which always uses set_attributes because we need to be conservative about custom elements).

The next step will be to generate code differently so as to fix #13270, but merging this first will reduce the noise of that work substantially. I'll self-merge this once green, since it's just moving some code around, so that I can continue working on that.

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: ad34112

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class:/style: directives can be overridden by class/style attributes
1 participant