Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RubyGem package #652

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Add RubyGem package #652

merged 2 commits into from
Jul 28, 2024

Conversation

MacFJA
Copy link
Collaborator

@MacFJA MacFJA commented Jul 27, 2024

This PR add the possibility to add package that are not on NPM.
More specifically from RubyGem

Related to #651

🎯 Changes

  • Allow to have npm or gem in packages.json (instead of only npm)
  • Change the package manager drop to allow to select a manager for Gem
  • Display a link for repository that are not GitHub or Gitlab

✅ Checklist

  • I have given my PR a descriptive title
  • I have run pnpm run lint locally on my changes

@vercel Vercel
Copy link

vercel bot commented Jul 27, 2024

@MacFJA is attempting to deploy a commit to the Svelte Society Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Jul 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sveltesociety-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 2:52pm

reesericci
reesericci approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@reesericci reesericci mentioned this pull request Jul 27, 2024
Merged
1 task
kevmodrome
kevmodrome approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@kevmodrome kevmodrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MacFJA MacFJA merged commit 5f5ebdf into svelte-society:main Jul 28, 2024
3 of 4 checks passed
@MacFJA MacFJA deleted the external-package-source branch July 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmodrome kevmodrome kevmodrome approved these changes

@reesericci reesericci reesericci approved these changes

@benmccann benmccann Awaiting requested review from benmccann

@lachlancollins lachlancollins Awaiting requested review from lachlancollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MacFJA @kevmodrome @reesericci