Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create more GitHub issue/pr template #518 #650

Conversation

jorgelaranjo
Copy link

🎯 Changes

Adds

.github/PULL_REQUEST_TEMPLATE/add_update_component.md
.github/PULL_REQUEST_TEMPLATE/delete_component.md
.github/PULL_REQUEST_TEMPLATE/other_changes.md
.github/ISSUE_TEMPLATE/request_change.md

Also makes old template available on new folder and keeps a copy on the current location not to break functionality as-is

as per #518 request

✅ Checklist

  • I have given my PR a descriptive title
  • I have run pnpm run lint locally on my changes

Copy link

vercel bot commented Jul 22, 2024

@jorgelaranjo is attempting to deploy a commit to the Svelte Society Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sveltesociety-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 0:48am

Comment on lines +9 to +11
## 📸 Screenshots (if applicable)

<!-- Include screenshots of the new or updated component/tool/template if applicable. -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about this section.
We don't have a screenshot on packages or templates.

@@ -0,0 +1,22 @@
## 🎯 Changes

<!-- Describe the changes made in this PR. Is it a new component, tool, or template? Or is it an update to an existing one? -->
Copy link
Collaborator

@MacFJA MacFJA Jul 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Describe the changes made in this PR. Is it a new component, tool, or template? Or is it an update to an existing one? -->
<!-- Describe the changes made in this PR. Is it a new package or template? Or is it an update to an existing one? -->

The distinction between component and tool have been removed.
There are only 6 kind of content (and 2 for external source code):

  • package (before it was component and tools)
  • template
  • recipe
  • cheat sheet
  • event
  • resource (video, books)

@@ -0,0 +1,18 @@
## 🗑️ Deletion Request

<!-- Describe the component/template/tool that is being deleted and the reasons for its removal. -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Describe the component/template/tool that is being deleted and the reasons for its removal. -->
<!-- Describe the package/template that is being deleted and the reasons for its removal. -->

@kevmodrome
Copy link
Member

This is great for the current site, but as we're gearing up to release the new site at the end of the month, I think it's unnecessary to implement. We'll be using a submission system on the actual site to add things.

@kevmodrome kevmodrome closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants