Skip to content

Commit

Permalink
bug fix and merge pull request. (see change.md)
Browse files Browse the repository at this point in the history
  • Loading branch information
suzuki-0000 committed Mar 29, 2018
1 parent f7d97a5 commit 327ff4a
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 9 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

## 5.0.7

#### Updated
- #301 SKPhotoBrowserOptions.displayCounterLabel is not working
- #297 I want to hide SKPagingScrollView's horizontal indicator by mothule

## 5.0.6

#### Updated
Expand Down
2 changes: 2 additions & 0 deletions SKPhotoBrowser/SKPaginationView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ private extension SKPaginationView {
}

func setupCounterLabel() {
guard SKPhotoBrowserOptions.displayCounterLabel else { return }

let label = UILabel(frame: CGRect(x: 0, y: 0, width: 100, height: 50))
label.center = CGPoint(x: frame.width / 2, y: frame.height / 2)
label.textAlignment = .center
Expand Down
5 changes: 2 additions & 3 deletions SKPhotoBrowser/SKPhotoBrowser.swift
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,8 @@ private extension SKPhotoBrowser {
}

func configureGestureControl() {
guard !SKPhotoBrowserOptions.disableVerticalSwipe else {
return
}
guard !SKPhotoBrowserOptions.disableVerticalSwipe else { return }

panGesture = UIPanGestureRecognizer(target: self, action: #selector(SKPhotoBrowser.panGestureRecognized(_:)))
panGesture?.minimumNumberOfTouches = 1
panGesture?.maximumNumberOfTouches = 1
Expand Down
3 changes: 2 additions & 1 deletion SKPhotoBrowser/SKZoomingScrollView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ open class SKZoomingScrollView: UIScrollView {
}
}

fileprivate(set) var imageView: SKDetectingImageView!
fileprivate weak var browser: SKPhotoBrowser?

fileprivate(set) var imageView: SKDetectingImageView!
fileprivate var tapView: SKDetectingView!
fileprivate var indicatorView: SKIndicatorView!

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ class FromCameraRollViewController: UIViewController, SKPhotoBrowserDelegate, UI
}

func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {

let cell = collectionView.dequeueReusableCell(withReuseIdentifier: "exampleCollectionViewCell", for: indexPath)
let asset = assets[(indexPath as NSIndexPath).row]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ class FromLocalViewController: UIViewController, UICollectionViewDataSource, UIC
setupCollectionView()
}

override func didReceiveMemoryWarning() {
super.didReceiveMemoryWarning()
}

override var prefersStatusBarHidden: Bool {
return false
}
Expand Down

0 comments on commit 327ff4a

Please sign in to comment.