Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Conflicting dependency + issues for psql #131

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

gsilvapt
Copy link
Contributor

@gsilvapt gsilvapt commented May 19, 2023

Tried a clean start and had issues installing the latest of black, as well as starting a Postgres DB.

Not sure why the tests are not failing with these errors? :(

Black

Seems Black==23.3.0 has requirements for packaging which is not compliant with other existing dependencies. Let's revert this change so we can continue building the project.

ERROR: Cannot install -r surface/requirements.txt (line 13), -r surface/requirements_dev.txt (line 3), -r surface/requirements_test.txt (line 3) and packaging==21.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested packaging==21.0
    django-jsoneditor 0.1.6 depends on packaging
    pytest 7.2.2 depends on packaging
    black 23.3.0 depends on packaging>=22.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

Postgres issue

                                                                                                                                                                                                                                                                                                                                                                                            
      pg_config is required to build psycopg2 from source.  Please add the directory                                                                                                                                                                                                                                                                                                        
      containing pg_config to the $PATH or specify the full executable path with the                                                                                                                                                                                                                                                                                                        
      option:                                                                                                                                                                                 

The latest version does not cause this.

@gsilvapt gsilvapt changed the title misc: Circular dependency + issues for psql misc: Conflicting dependency + issues for psql May 19, 2023
@gsilvapt gsilvapt marked this pull request as ready for review May 22, 2023 08:52
@gsilvapt gsilvapt requested a review from a team as a code owner May 22, 2023 08:52
@gsilvapt gsilvapt requested review from tcppb and fpintoppb May 22, 2023 08:52
@DDuarte
Copy link
Contributor

DDuarte commented Jul 6, 2023

perhaps packaging can be bumped instead? https://github.com/surface-security/surface/blob/main/surface/scanners/requirements.txt#L2

@gsilvapt
Copy link
Contributor Author

gsilvapt commented Jul 6, 2023

perhaps packaging can be bumped instead? https://github.com/surface-security/surface/blob/main/surface/scanners/requirements.txt#L2

Yep, this worked well. Pushed the change. Thanks!

@gsilvapt gsilvapt requested review from DDuarte and removed request for tcppb and fpintoppb July 6, 2023 09:28
@DDuarte DDuarte merged commit 34efefe into main Jul 6, 2023
10 checks passed
@gsilvapt gsilvapt deleted the fix-dependency_problems branch July 6, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants