fix: magiclink failing due to passwordStrength check #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klajdi369
changed the title
klajdi369
force-pushed
the
fix-magiclink-requiredchars
branch
from
deb465d
to
07a44bc
Compare
klajdi369
force-pushed
the
fix-magiclink-requiredchars
branch
from
999c09e
to
fb1a58c
Compare
Pull Request Test Coverage Report for Build 10800290811Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
cstockton
reviewed
Sep 17, 2024
Comment on lines
+9
to
+17
| // parseGroups processes the required character groups from a slice of strings. | ||
| func parseGroups(requiredChars []string) []string { | ||
| var groups []string | ||
| groups = append(groups, requiredChars...) | ||
| return groups | ||
| } | ||
|
|
||
| func GeneratePassword(requiredChars []string, length int) (string, error) { | ||
| groups := parseGroups(requiredChars) |
There was a problem hiding this comment.
I think we can reference the parameter directly since we don't mutate the slice.
Suggested change
| // parseGroups processes the required character groups from a slice of strings. | |
| func parseGroups(requiredChars []string) []string { | |
| var groups []string | |
| groups = append(groups, requiredChars...) | |
| return groups | |
| } | |
| func GeneratePassword(requiredChars []string, length int) (string, error) { | |
| groups := parseGroups(requiredChars) | |
| func GeneratePassword(requiredChars []string, length int) (string, error) { |
| passwordBuilder.Grow(length) | ||
|
|
||
| // Add required characters | ||
| for _, group := range groups { |
There was a problem hiding this comment.
Suggested change
| for _, group := range groups { | |
| for _, group := range requiredChars { |
| } | ||
|
|
||
| // Define a default character set for random generation (if needed) | ||
| allChars := "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789" |
There was a problem hiding this comment.
Suggested change
| allChars := "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789" | |
| const allChars = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789" |
There was a problem hiding this comment.
If we can move this into internal/crypto/password.go I think the change will look good to me. A unit test would be a nice addition if time permits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
#1761
What is the new behavior?
Now the password should generate secure enough with the necessary password requirements specified in environment variables.
Additional context
Basically this line in /internal/api/magic_link.go
password.Generate(64, 10, 1, false, true)
Generates an invalid value for this line in /internal/api/signup.go
if err := a.checkPasswordStrength(ctx, p.Password); err != nil {