Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the update_settings utility #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zefciu
Copy link
Contributor

@zefciu zefciu commented Sep 6, 2019

Added a utility to modify dictionary settings. Usage explained in docs.

@zefciu zefciu requested a review from dekoza September 6, 2019 09:31
@zefciu zefciu force-pushed the update-settings branch 2 times, most recently from 09770b9 to 8a129d1 Compare September 6, 2019 10:08
@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #32 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   95.45%   95.62%   +0.17%     
==========================================
  Files           5        6       +1     
  Lines         330      343      +13     
==========================================
+ Hits          315      328      +13     
  Misses         15       15
Impacted Files Coverage Δ
djet/util.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e28278...cea0eaf. Read the comment docs.

Copy link

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost lgtm

`modify_settings`. The first allows you to simply override a value. The latter
– to manipulate lists (like `INSTALLED_APPS`). Djet supplements it with
`update_settings` that allows you to manipulate settings in form of
dictionaries. The arguments to `update_settings` should be dictionaries with

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not only dictionaries but also names of options. IDK how should look precise wording for that in english.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants