Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Possibility to refer to URL instead of IP address #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sofianinho
Copy link

@sofianinho sofianinho commented Nov 16, 2018

Hello,

In my tests, I wanted to control the car through a URL hostname instead of an IP address in the client.py.
I had to change the following:

  • The user interface in the form dir not allow that many characters. The limit was 16 (full ip address). I raised it to 50.
  • The port was added no matter what, causing incorrect URLs and unreachable destinations. There is now a test to know if the ":" needs to be added after the host.

For users of this feature:

  • You can test this using something like "duckdns" or "ngrok". Be careful: in order for your interface to work properly, you need 2 ports to be reachable: 8080 for the camera and 8000 for the controls.
    I you use the free version of ngrok, only one port can be open at once with one URL, unless you hack it :-). If you did, you would notice that URLs are different, and your client UI would then require an additional field for the camera URL and port. This is not implemented in this version.
    ->If you use duckdns, you have both ports reachable, and the interface works.
    These limitations are those of your public reachable hostnames and their providers, not the code itself.

Hopefully this will be accepted, I found a use for it in my lab to remotely control the car (not in the same LAN).

Best regards,
Sofiane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant