-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LSP-PowerShellEditorServices #27
Conversation
02653dc
to
89ee7ee
Compare
OK... With a simple CURL action I can finally see what's wrong:
So it's indeed related to this PR being created by the bot. |
I think the solution for that is to have a bot account that will have its own token and we'll use that for the review bot. |
Or... How about not reporting results via a quirky "request changes" comment, but rather look at the failed actions. |
That's not very user friendly, having to look for details of the error in the shell output... |
The repository json checks could also be presented as "annotations" https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-status-checks |
This release contains version v2.2.0 of PowerShellEditorServices. Sublime-Text-Version-Range: >=4070
89ee7ee
to
5925208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: LSP-PowerShellEditorServices
Results help
Packages added:
- LSP-PowerShellEditorServices
Processing package "LSP-PowerShellEditorServices"
- ERROR: fetching package HTTP error 302 downloading https://github.com/sublimelsp/LSP-PowerShellEditorServices/releases/download/v1.1.1/LSP-PowerShellEditorServices.zip.
Right, but I feel that would be pretty tricky to implement since the checks don't really keep track of line numbers right now. I mean the review bot checks at least. |
Need to figure out a solution for the redirect issue. |
There's an issue for it wbond/package_control#1502 |
Do you think we should wait for that or implement a solution on our side (have links that don't redirect)? |
It should be fixed in package control because we might not be the only ones having this issue. |
Yes but ST3 version of PC will not get a fix so if we want to support some ST3 packages then we should probably do something ourselves. That said, I guess the ones you've created are all ST4+. EDIT: Actually LSP-lua isn't. |
I give up. Let's download all the files with our own tooling. Made the appropriate reverts in the helper package repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: LSP-PowerShellEditorServices
Results help
Packages added:
- LSP-PowerShellEditorServices
Processing package "LSP-PowerShellEditorServices"
- ERROR: fetching package HTTP error 302 downloading https://github.com/sublimelsp/LSP-PowerShellEditorServices/releases/download/v1.1.1/LSP-PowerShellEditorServices.zip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: LSP-PowerShellEditorServices
Results help
Packages added:
- LSP-PowerShellEditorServices
Processing package "LSP-PowerShellEditorServices"
- ERROR: fetching package HTTP error 302 downloading https://github.com/sublimelsp/LSP-PowerShellEditorServices/releases/download/v1.1.1/LSP-PowerShellEditorServices.zip.
Why aren't you picking up tag 1.1.2 @STReviewBot ? |
Is it maybe because of the "url" or the "version" key? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: LSP-PowerShellEditorServices
Results help
Packages added:
- LSP-PowerShellEditorServices
Processing package "LSP-PowerShellEditorServices"
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 23, Column: 12
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 117, Column: 11
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 121, Column: 12
Repo link
https://github.com/sublimelsp/LSP-PowerShellEditorServices
Release body
This release contains version v2.2.0 of PowerShellEditorServices.
Sublime-Text-Version-Range: >=4070