Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add test case for 'FUEL' paper #2239

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

danielmayer
Copy link
Contributor

@danielmayer danielmayer commented Mar 11, 2024

Proposed Changes

This pull request adds the test case that we used for the Fuel paper.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@danielmayer danielmayer added PR: draft Testcase Pull request that introduces a new testcase labels Mar 11, 2024
@danielmayer danielmayer changed the title Add test case for fuel paper Add test case for 'Fuel' paper Mar 11, 2024
@danielmayer danielmayer changed the title Add test case for 'Fuel' paper Add test case for 'FUEL' paper Mar 11, 2024
@bigfooted
Copy link
Contributor

@danielmayer where does the python script for FADO go? here or in the Testcases repository?

@danielmayer
Copy link
Contributor Author

@danielmayer where does the python script for FADO go? here or in the Testcases repository?

Good question. I think the purpose of the TestCases repo is to separate large files that don't change much from the code base. Since those scripts are small, I would lean towards putting them in the SU2 repo. Another option is to add them as a new test case to FADO, but that adds another layer of complexity. What do you think? What does @pcarruscag think?

@pcarruscag
Copy link
Member

TestCases repo is used for large files that are used in regression tests.
Then we have the tutorials repo for tutorial files (mesh + configs) and we also exercise those in regressions.
If this is too large for either of the above it should go into V&V, I guess that is how it was used for the paper?

@bigfooted
Copy link
Contributor

If this is too large for either of the above it should go into V&V, I guess that is how it was used for the paper?

I suggest we add this to the regression tests, put the mesh in the testcases repo, and add additional scripts and results to the V&V and create a V&V page pointing to the paper and showing some main results.

@pcarruscag pcarruscag changed the title Add test case for 'FUEL' paper [WIP] Add test case for 'FUEL' paper Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:chore PR: draft Testcase Pull request that introduces a new testcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants