[WIP] Update turbo interfaces #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshkellyjak
changed the title
pcarruscag
reviewed
Feb 13, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Workaround for ASLR/tsan incompatibility
Added gprof profiling option
…gle value is provided
…_solid-solid_cht
Solid to solid conjugate heat transfer with contact resistance
|
|
||
| /*--- Compute and update residual. Note that the viscous shear stress tensor is computed in the | ||
| following routine based upon the velocity-component gradients. ---*/ | ||
| auto residual = visc_numerics->ComputeResidual(config); |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
| @@ -161,8 +175,10 @@ | |||
|
|
|||
| /*--- Roe-averaged speed of sound ---*/ | |||
|
|
|||
| //RoeSoundSpeed2 = Gamma_Minus_One * ( RoeEnthalpy - 0.5 * sq_velRoe ); | |||
Check notice
Code scanning / CodeQL
Commented-out code Note
joshkellyjak
changed the base branch from
develop
to
feature_turbo_interfaces
joshkellyjak
merged commit d106401
into
su2code:feature_resolve_merge_turbo_interfaces
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update to the interface initialisation to enable both mixing plane and sliding interfaces within the same turbomachinery simulation. Addition of mass flow outlet to Giles BC.
Related Work
This issue solves a problem reported by a number of users, when simulating radial turbomachinery cases a second-order accurate solution cannot be achieved in some cases when using mixing plane interfaces. This is due to circumfrential averaging in regions where the flow exhibits large circumfrential nonuniformity and/or interspace gaps between adjacent blade-rows/zones small. This issue has been reported by @LorenzoFabris, in a presentation at the SU2 Conference 2022 "Performance Analysis and Shape Optimization of a Radial Compressor with the Open-Source Software SU2" and by myself.
Mass flow outlet included in the PR as requested by users.
TBC:
-Update APU Turbocharger test case and regression test to include this feature, add diffuser and converge 2nd order.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.