Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new example for adjoint fluid flow with custom mesh deformation, fix CGNS issue with compiler flags #2059

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

pcarruscag
Copy link
Member

Proposed Changes

image

I'm also working on an unsteady version, but there is something wrong with the unsteady adjoint.

Related Work

Fixes #2058

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

TestCases/py_wrapper/wavy_wall/run_steady.py Outdated Show resolved Hide resolved
TestCases/py_wrapper/wavy_wall/run_steady.py Outdated Show resolved Hide resolved
TestCases/py_wrapper/wavy_wall/run_steady.py Outdated Show resolved Hide resolved
.github/workflows/regression.yml Outdated Show resolved Hide resolved
@pcarruscag pcarruscag merged commit 0fc0d07 into develop Jun 25, 2023
26 checks passed
@pcarruscag pcarruscag deleted the py_wrapper_example branch June 25, 2023 07:52
@pcarruscag
Copy link
Member Author

For completeness, unsteady adjoints do not work for this type of case due to a dependence of the solution on old coordinates (to compute grid velocities) and old volumes (for the dual time derivative) which we do not handle correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant