This repository has been archived by the owner on May 23, 2021. It is now read-only.
Slim & PHP8 update #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
commented
Dec 12, 2020
| "confirmation_method" => "manual", | ||
| "confirm" => true, | ||
| // 3D Payment is not supported by this script, but the return_url is required in many cases. | ||
| "return_url"=> "http://localhost:4242/", |
There was a problem hiding this comment.
This is the only change related to stripe. On my account, it was required to add this to make it work. I assume it's optional if your account is not set with 3DSecure only.
Anyway, it just changes basically nothing for most users, I can roll it back if you want. But I think keeping it is a good thing.
|
Thanks for the PR, @Nek. Does this require upgrading to PHP8? |
No, this works with php7. However, I didn't test it. And I suspect the composer.lock to be an issue to make this work properly. I can remove the composer.lock if you want. Also I should test it :) . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks
Here is an update of your PHP example, it now works with PHP8 :) . (last major version)