Allow templating of host and advertisedHost fields
#10605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
changed the title
host and advertisedHost fields
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run helm-acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PaulRMellor
approved these changes
Sep 20, 2024
documentation/api/io.strimzi.api.kafka.model.kafka.listener.GenericKafkaListener.adoc
Outdated
Show resolved
Hide resolved
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.GenericKafkaListenerConfiguration.adoc
Outdated
Show resolved
Hide resolved
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.GenericKafkaListenerConfiguration.adoc
Outdated
Show resolved
Hide resolved
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.GenericKafkaListenerConfiguration.adoc
Outdated
Show resolved
Hide resolved
...n/api/io.strimzi.api.kafka.model.kafka.listener.GenericKafkaListenerConfigurationBroker.adoc
Outdated
Show resolved
Hide resolved
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.GenericKafkaListenerConfiguration.adoc
Outdated
Show resolved
Hide resolved
...c/main/java/io/strimzi/api/kafka/model/kafka/listener/GenericKafkaListenerConfiguration.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/strimzi/api/kafka/model/kafka/listener/GenericKafkaListenerConfiguration.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ListenersValidator.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ListenersValidator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
scholzj
force-pushed
the
allow-templating-of-host-and-advertisedHost-fields
branch
from
b4fc080
to
0411ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR implements the Strimzi Proposal 84 and adds support for templating
hostandadvertisedHostfields in the listener configuration. Thehostfields apply to route and ingress type listeners, the advertised hosts can be used with any listener. The implementation is as describe int he proposal.Checklist