fix the undo/redo button visibility on mobile #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay variant - Updated the Tokyonight theme to the Tokyonight Moon variant - Added a new variant, Tokyonight Day, following the namescheme of the Tokyonight project - Included JSON and CSS files for both variants - Ensured consistency with the original Tokyonight color scheme
…tesnook-themes into add-rose-pine-theme
|
Your preview URL is: https://theme-builder.notesnook.com/notes?from_pr=streetwriters/notesnook-themes/92 |
|
I don't think this change should be necessary. The issue is in the UI itself. The color for disabled buttons should be derived from the color of the button instead of being based on the border color. |
|
Thanks for the feedback. I'm going to close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colors of the undo/redo buttons were similar to the background, making it hard to see, specially on mobile. This changes make it a lot more readable.
Before
After