Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace permission grants #23

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Add namespace permission grants #23

merged 1 commit into from
Jan 5, 2021

Conversation

ypt
Copy link
Contributor

@ypt ypt commented Dec 21, 2020 •
edited
Loading

Usage follows the description here: #8

resource "pulsar_namespace" "test" {
  ...
  permission_grant {
    role = "my-consumer"
    actions = ["consume"]
  }
}

This PR also includes a few other misc changes to get the integration test suite passing - which I've pointed out in the GitHub comments below. That said, if there's a better way to go about those, please let me know and I'd be happy to make adjustments.

If we feel like this is all headed in the right direction, I can also work on an analogous PR for topic permission grants.

This was referenced Dec 21, 2020
Merged
Closed
@ypt
Add namespace permission grants
2d14930 
Usage follows the description here: streamnative#8

```
resource "pulsar_namespace" "test" {
  ...
  permission_grant {
    role = "my-consumer"
    actions = ["consume"]
  }
}
```
@ypt ypt force-pushed the add-namespace-permission-grants branch from a9a996a to 2d14930 Compare December 22, 2020 16:06
@ypt ypt mentioned this pull request Dec 22, 2020
Open
@sijie sijie requested review from zymap and a team December 28, 2020 22:21
sijie pushed a commit that referenced this pull request Dec 28, 2020
@ypt
Fix dispatch_rate and retention_policies state key usage for namespace (
3bd77d9 
#22)

I stumbled across these minor issues while working on #23 / #8

1. A few state keys were not being set correctly in the namespace resource
2. A fix for this warning:
    > conversion from int to string yields a string of one rune,
    > not a string of digits (did you mean fmt.Sprint(x)?)
@sijie
Copy link
Member

sijie commented Jan 5, 2021

@ypt great contribution!

@sijie sijie merged commit 3434003 into streamnative:master Jan 5, 2021
@ypt ypt deleted the add-namespace-permission-grants branch January 6, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@zymap zymap Awaiting requested review from zymap

Assignees

@ypt ypt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ypt @sijie