cosmwasm: add wormchain ibc receiver tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakucodes
requested review from
claudijd,
johnsaigle and
nik-suri
as code owners
kakucodes
changed the title
jtieri
reviewed
Sep 18, 2024
There was a problem hiding this comment.
We determined the changes look good and test coverage w.r.t to Rust side seems like it has achieved what it can due to limitations. A follow up PR will be made to add additional test cases with interchaintest
Once CI is passing this is good to merge.
One note we had is that we want to ensure the Wormchain teams take a look at these changes to ensure it meets their expectations and coding styles.
…chore-add-wormchain-receiver-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds tests to the
wormchain-ibc-receivercontract to ensure that adding channels functions properly.