tests: Remove resolve_device tests involving partition creation #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of commit cf47eee that depends on full object update after partitioning. That is still work in progress (see storaged-project#955) and prone to race conditions. ====================================================================== FAIL: test_60_resolve_device (test_10_basic.UdisksBaseTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/workspace/udisks-pr/arch/x86_64/distro/centos_9s/type/udisks/src/tests/dbus-tests/test_10_basic.py", line 335, in test_60_resolve_device self.assertEquals(part_name_val, part_label) AssertionError: dbus.String('', variant_level=1) != 'PRTLBLX'
vojtechtrefny
approved these changes
Nov 4, 2022
|
Can you maybe add the test back in #955 (or revert the revert) to make sure we won't forget to add the tests back once it is fixed? |
That's my plan, once this is merged, I'll rebase and revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of commit cf47eee that depends on full object update after partitioning. That is still work in progress (see #955) and prone to race conditions.
======================================================================
FAIL: test_60_resolve_device (test_10_basic.UdisksBaseTest)
Traceback (most recent call last):
File "/home/jenkins/workspace/udisks-pr/arch/x86_64/distro/centos_9s/type/udisks/src/tests/dbus-tests/test_10_basic.py", line 335, in test_60_resolve_device
self.assertEquals(part_name_val, part_label)
AssertionError: dbus.String('', variant_level=1) != 'PRTLBLX'