GameDB: Fix MGS Premium Package #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenzek
reviewed
Sep 6, 2024
| discSet: | ||
| name: "Metal Gear Solid (Asia)" | ||
| name: "Metal Gear Solid (Japan, Asia) (Premium Package)" |
There was a problem hiding this comment.
Hopefully this one wasn't actually being detected before, because otherwise it's going to change memory card names.
There was a problem hiding this comment.
Oh, I didn't think of that... 😓
But yeah, the disc set wasn't detected before (at least on my testings on Windows 10), instead both discs were added to the game list as 2 separate entries but with the same Metal Gear Solid [Premium Package Sai Hakkou Kinen] name:
Should I make a new PR and use that name as the disc set name to make it "backward compatible"?
There was a problem hiding this comment.
Eh, don't worry about it. It's not like it deletes old cards, users would just have to rename them.
stenzek
pushed a commit
that referenced
this pull request
Sep 18, 2024
stenzek
pushed a commit
that referenced
this pull request
Sep 18, 2024
stenzek
pushed a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed discs according to Redump, added the alternative serials and removed the incorrect entries where the game was considered as a single disc.