Cleanup apply and validation flows #4471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4318 - main change is to stop passing around Application during validation and application flows, and use AppConnector instead, which is forced to either assert main thread or implement thread-safe methods
Resolves #3800 - note that READ_ONLY_WITHOUT_SQL_TXN LedgerTxn mode should go away completely once we switch to mandatory BucketListDB. It looks like we were using RO LedgerTxn during apply scenarios, which I think is not legal? Either way, all READ_ONLY_WITHOUT_SQL_TXN usages except for the legacy one in LedgerSnapshot have been removed now.
Note that the second commit has a huge diff but is a no-op, as it's basically a find and replace for
Application -> AppConnector