Update weight function to fix bias in nomination #4453
Merged
+885
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested changes
Sep 9, 2024
bboston7
commented
Sep 11, 2024
|
This is ready for another round of review! |
|
Feel free to squash fixup commits and rebase also to prepare for merging |
Part of stellar#4387 This change adds an application-specific `HerderSCPDriver::getNodeWeight` function that computes a validator's weight based on its quality as described in the config file. Much of this change is in the testing infrastructure, which stresses the new algorithm to demonstrate that it avoids biasing towards larger orgs. The remaining work (to be done in follow up PRs) is: * Documentation explaining the new algorithm in `src/herder/readme.md` * A supercluster mission testing the upgrade from the old weight function to the new one.
bboston7
force-pushed
the
scp-nomination
branch
from
42f20e6
to
4b0fd8d
Compare
Done! |
marta-lokhova
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #4387
This change adds an application-specific
HerderSCPDriver::getNodeWeightfunction that computes a validator's weight based on its quality as described in the config file. Much of this change is in the testing infrastructure, which stresses the new algorithm to demonstrate that it avoids biasing towards larger orgs.The remaining work (to be done in follow up PRs) is:
src/herder/readme.mdChecklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)