-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat_: support xcode 16 #21345
base: develop
Are you sure you want to change the base?
feat_: support xcode 16 #21345
Conversation
after upgrading to |
Jenkins Builds
|
86% of end-end tests have passed
Failed tests (7)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (44)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
|
Sorry @qfrank, I can't review PRs targeting only Apple devices 🤷🏼 |
We will have to upgrade Xcode to 16.0 in CI hosts for this change to work. |
Would be good to confirm with several developers that Xcode 16 works well for them before we commit to upgrading CI hosts. |
yes that is indeed something we should verify! |
@churik : yes this is known race condition, you can close terminal which is running metro. restart metro with |
emm..
Am I doing something wrong @siddarthkay ? |
@churik : can you confirm if |
Confirmed, could build an app Sonoma 14.5 / Xcode 16. Instructions on how to workaround a race condition (thanks @siddarthkay ):
Once you see metro has started, navigate in iOS Simulator and tap on status debug app icon. this should load the app fine. |
100% of end-end tests have passed
Passed tests (7)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
We should still wait till we hear from other mobile devs on Xcode 16 usage and once we upgrade Xcode in CI to 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it worked fine after make nix-update-pods
stackoverflow reference
status: ready.