Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap react-native-mail fork with patch #19688

Merged
merged 1 commit into from
Apr 18, 2024
Merged

swap react-native-mail fork with patch #19688

merged 1 commit into from
Apr 18, 2024

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Apr 17, 2024 •
edited
Loading

Summary

This PR swaps the fork of react-native-mail with a patch.

needed for : #18138

Review & Test notes

Verify if mailing logs still works.

Platforms

  • iOS
  • Android

status: ready

@siddarthkay siddarthkay self-assigned this Apr 17, 2024
@siddarthkay siddarthkay requested a review from a team April 17, 2024 09:55
@status-im-auto
Copy link
Member

status-im-auto commented Apr 17, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e8cdb9e #1 2024-04-17 10:00:29 ~5 min tests 📄log
✔️ e8cdb9e #1 2024-04-17 10:02:52 ~7 min android-e2e 🤖apk 📲
✔️ e8cdb9e #1 2024-04-17 10:03:10 ~8 min android 🤖apk 📲
✔️ e8cdb9e #1 2024-04-17 10:05:01 ~10 min ios 📱ipa 📲
✔️ 5351c52 #2 2024-04-17 14:37:40 ~11 min android-e2e 🤖apk 📲
✔️ 5351c52 #2 2024-04-17 14:37:56 ~12 min android 🤖apk 📲
✔️ 5351c52 #2 2024-04-17 14:38:01 ~12 min tests 📄log
✔️ 5351c52 #2 2024-04-17 14:38:52 ~13 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ afb2606 #4 2024-04-18 08:02:02 ~6 min tests 📄log
✔️ afb2606 #4 2024-04-18 08:03:49 ~8 min android-e2e 🤖apk 📲
✔️ afb2606 #4 2024-04-18 08:05:14 ~10 min android 🤖apk 📲
✔️ afb2606 #4 2024-04-18 08:09:18 ~14 min ios 📱ipa 📲
✔️ d872a00 #5 2024-04-18 08:46:04 ~5 min tests 📄log
✔️ d872a00 #5 2024-04-18 08:48:01 ~7 min android 🤖apk 📲
✔️ d872a00 #5 2024-04-18 08:48:36 ~8 min android-e2e 🤖apk 📲
✔️ d872a00 #5 2024-04-18 08:50:13 ~9 min ios 📱ipa 📲

@siddarthkay
Copy link
Contributor Author

@status-im/mobile-qa : just a smoke test for this PR will do

@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 52
Failed tests: 2
Expected to fail tests: 2
Passed tests: 48

IDs of failed tests: 727230,704615 

IDs of expected to fail tests: 703495,703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615

    Device 1: Looking for a message by text: text after edit
    Device 1: Looking for a message by text: message to delete 

    critical/chats/test_public_chat_browsing.py:800: in test_community_edit_delete_message_when_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Updated message 'text after edit' is not delivered to the receiver
E    Message 'message to delete' was not deleted for the receiver



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.0184 ETH 

    critical/test_wallet.py:126: in test_wallet_send_asset_from_drawer
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:97: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the senders wallet is 0.0578 but should be 0.0577
E    Eth amount in the receivers wallet is 0.0184 but should be 0.0185



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Passed tests (48)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    @siddarthkay siddarthkay force-pushed the fork-to-patch-for-mail-lib branch 2 times, most recently from 1a56e96 to afb2606 Compare April 18, 2024 07:54
    @siddarthkay
    Copy link
    Contributor Author

    @status-im/mobile-qa : please smoke test this PR briefly, The only flow that should be impacted would be sending of the email we use for sharing logs.
    Thank you!

    @qoqobolo
    Copy link
    Contributor

    @status-im/mobile-qa : please smoke test this PR briefly, The only flow that should be impacted would be sending of the email we use for sharing logs. Thank you!

    Hey, since this is a really small change and this is the only thing that might be impacted, it makes sense to skip manual QA in this case according to the new process.
    Would you mind just checking this flow yourself and merging it please?🙂🙏
    I've checked the e2e results, they are okay👌

    @siddarthkay
    Copy link
    Contributor Author

    Thanks @qoqobolo : I tested it just now and sending email flow seems to work!
    Thanks for taking a look at the E2E.

    @siddarthkay
    swap react-native-mail fork with patch
    d872a00 
    ## Summary

This commit swaps the fork of react-native-mail with a patch.

needed for : #18138

## Review & Test notes

Verify if mailing logs still works.

## Platforms
- iOS
- Android

status: ready
    @siddarthkay siddarthkay merged commit a6b19c0 into develop Apr 18, 2024
    6 checks passed
    @siddarthkay siddarthkay deleted the fork-to-patch-for-mail-lib branch April 18, 2024 08:59
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @OmarBasem OmarBasem OmarBasem approved these changes

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    Assignees

    @siddarthkay siddarthkay

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @siddarthkay @status-im-auto @qoqobolo @Parveshdhull @ajayesivan @OmarBasem @mohsen-ghafouri