chore_: bump go-waku with filter loop fix #5909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (65)
|
chaitanyaprem
force-pushed
the
fix/filter-loop
branch
3 times, most recently
from
c88980c
to
552c359
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #5909 +/- ##
===========================================
- Coverage 47.79% 47.45% -0.34%
===========================================
Files 834 834
Lines 137749 137818 +69
===========================================
- Hits 65843 65408 -435
- Misses 64308 64635 +327
- Partials 7598 7775 +177
Flags with carried forward coverage won't be shown. Click here to find out more. |
siddarthkay
force-pushed
the
fix/filter-loop
branch
from
c3e5c34
to
ae9102f
Compare
siddarthkay
force-pushed
the
fix/filter-loop
branch
from
0fc4d70
to
d91f1d0
Compare
richard-ramos
force-pushed
the
fix/filter-loop
branch
from
d91f1d0
to
0d876d1
Compare
|
Let's see if it works now after rebasing the .gitignore change! |
|
@richard-ramos : you might have forgotten to push vendor change 😉 |
le sigh... |
richard-ramos
force-pushed
the
fix/filter-loop
branch
from
0d876d1
to
9e2f128
Compare
chaitanyaprem
requested review from
richard-ramos,
a team,
plopezlpz and
kaichaosun
richard-ramos
approved these changes
Oct 9, 2024
plopezlpz
approved these changes
Oct 9, 2024
chaitanyaprem
force-pushed
the
fix/filter-loop
branch
2 times, most recently
from
cba9f25
to
2ff0766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates go-waku with many fixes and improvements along with filter loop fix.
this PR is to be used for testing and identifying issues being noticed in status-mobile tests wrt peers not connected apart from store nodes.
all underlying commits have been dogfooded separately. @richard-ramos can confirm the same.
Important changes:
Closes #