Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: use a single content-topic for all community chats #5864

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chaitanyaprem
Copy link
Contributor

@chaitanyaprem chaitanyaprem commented Sep 23, 2024

This PR is first step i moving towards using a single content-topic for all community chats and most of the control messages.
Once this is released , in a subsequent release we can disable installing filters using chatIDs for communities altogether.

Detailed proposal https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335

All channels shall use content-topic used for MemberUpdates .

Important changes:

  • pass MemberUpdatesChannelID to filter and use the same to determine when to use content-topic derived from communityID and not chatID.
  • note that only sending of messages shall use this new content-topic , receiving of messages shall work if msg is sent on older content-topic (based on chatID) or communityID based content-topic . this is to ensure non-breaking migration for existing users. In a subsequent release receiving and store queries would also be modified to use single content-topic
  • validated message send/receive with this code and 2.30 code in communities.
  • validate other actions of community
  • check if any other control messages that can be migrated to same content-topic.
  • validate send/receive with lightClients using new code and 2.30 release
  • dogfooded these changes locally by using this version of status-desktop in relay and light modes and also verifying messages sent are received between 2.30 desktop, mobile and this version of desktop(relay and light modes).
  • dogfooding by others in desktop and mobile interworking with 2.30 releases and testing all community features

@status-im-auto
Copy link
Member

status-im-auto commented Sep 23, 2024

Jenkins Builds

Click to see older builds (25)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0b9a61b #1 2024-09-23 06:23:18 ~2 min tests-rpc 📄log
✔️ 0b9a61b #1 2024-09-23 06:24:49 ~4 min linux 📦zip
✔️ 0b9a61b #1 2024-09-23 06:25:23 ~4 min ios 📦zip
✔️ 0b9a61b #1 2024-09-23 06:25:31 ~4 min android 📦aar
✖️ 0b9a61b #1 2024-09-23 06:58:57 ~38 min tests 📄log
✔️ 48283d7 #2 2024-09-25 09:07:35 ~2 min android 📦aar
✔️ 48283d7 #2 2024-09-25 09:07:47 ~2 min linux 📦zip
✖️ 48283d7 #2 2024-09-25 09:07:54 ~2 min tests 📄log
✔️ 48283d7 #2 2024-09-25 09:08:41 ~3 min ios 📦zip
✖️ 48283d7 #2 2024-09-25 09:09:32 ~4 min tests-rpc 📄log
✔️ 4f10919 #3 2024-09-26 11:10:52 ~2 min android 📦aar
✔️ 4f10919 #3 2024-09-26 11:11:08 ~2 min linux 📦zip
✔️ 4f10919 #3 2024-09-26 11:11:11 ~2 min tests-rpc 📄log
✔️ 4f10919 #3 2024-09-26 11:12:15 ~3 min ios 📦zip
✖️ 4f10919 #3 2024-09-26 11:40:36 ~31 min tests 📄log
✔️ 0a9ffb2 #4 2024-10-07 08:25:54 ~2 min tests-rpc 📄log
✔️ 0a9ffb2 #4 2024-10-07 08:27:27 ~3 min ios 📦zip
✔️ 0a9ffb2 #4 2024-10-07 08:27:46 ~4 min linux 📦zip
✔️ 0a9ffb2 #4 2024-10-07 08:27:49 ~4 min android 📦aar
✖️ 0a9ffb2 #4 2024-10-07 08:56:59 ~33 min tests 📄log
✔️ b6aaaf3 #5 2024-10-09 06:24:23 ~2 min android 📦aar
✔️ b6aaaf3 #5 2024-10-09 06:24:28 ~2 min tests-rpc 📄log
✔️ b6aaaf3 #5 2024-10-09 06:24:33 ~2 min linux 📦zip
✔️ b6aaaf3 #5 2024-10-09 06:25:32 ~3 min ios 📦zip
✖️ b6aaaf3 #5 2024-10-09 06:54:45 ~32 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 29b3c44 #6 2024-10-09 06:26:55 ~2 min tests-rpc 📄log
✔️ 29b3c44 #6 2024-10-09 06:27:16 ~2 min linux 📦zip
✔️ 29b3c44 #6 2024-10-09 06:28:45 ~3 min ios 📦zip
✔️ 29b3c44 #6 2024-10-09 06:29:59 ~5 min android 📦aar
✖️ 29b3c44 #6 2024-10-09 07:27:03 ~32 min tests 📄log
✔️ 8cb3323 #7 2024-10-09 08:14:04 ~2 min android 📦aar
✔️ 8cb3323 #7 2024-10-09 08:14:14 ~2 min linux 📦zip
✔️ 8cb3323 #7 2024-10-09 08:14:22 ~2 min tests-rpc 📄log
✔️ 8cb3323 #7 2024-10-09 08:15:05 ~3 min ios 📦zip
✔️ 8cb3323 #7 2024-10-09 08:43:11 ~31 min tests 📄log

@chaitanyaprem chaitanyaprem force-pushed the feat/comm-content-topic-poc branch 2 times, most recently from 48283d7 to 4f10919 Compare September 26, 2024 11:08
@chaitanyaprem chaitanyaprem force-pushed the feat/comm-content-topic-poc branch 3 times, most recently from b6aaaf3 to 29b3c44 Compare October 9, 2024 06:23
@chaitanyaprem chaitanyaprem changed the title feat_: poc to use single content-topic for all community chats feat_: use a single content-topic for all community chats Oct 9, 2024
@churik
Copy link
Member

churik commented Oct 9, 2024

Let's not merge it until the release branch for 2.31 is cut in status-go, seems PR might be very risky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants