fix_: add ticker to check peers and update connection status #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
requested review from
richard-ramos,
plopezlpz,
kaichaosun and
qfrank
Jenkins Builds
|
richard-ramos
approved these changes
Aug 10, 2024
kaichaosun
approved these changes
Aug 10, 2024
qfrank
approved these changes
Aug 11, 2024
|
@qfrank , anything else pending on this or else we can merge this. I don't have permissions to merge though. |
I'd say nothing pending on this @siddarthkay @cammellos |
|
Cherry picked into release, closing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not cherrypick actual commit from develop as there is some refactor of code in this section.
This is similar change to #5682 but for release branch.
Closes #5679
@qfrank : better to merge this for release since we are not taking latest develop.