feat_: dapp connected notification #5616
Draft
+609
−446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (30)
|
yqrashawn
force-pushed
the
feat/wallet-connect-session-notification
branch
from
9bc67a0
to
c9d0277
Compare
yqrashawn
force-pushed
the
feat/wallet-connect-session-notification
branch
2 times, most recently
from
f794844
to
f406cb5
Compare
ilmotta
reviewed
Jul 29, 2024
yqrashawn
force-pushed
the
feat/wallet-connect-session-notification
branch
from
f406cb5
to
177688f
Compare
|
Will request manual QA on the mobile side after 2.30 release |
mohsen-ghafouri
force-pushed
the
feat/wallet-connect-session-notification
branch
from
177688f
to
d608df7
Compare
igor-sirotin
reviewed
Sep 3, 2024
| } | ||
|
|
||
| _, err := m.persistence.SaveActivityCenterNotification(notification, true) | ||
|
|
There was a problem hiding this comment.
To notify client here, you'd do something like this:
if m.config.messengerSignalsHandler != nil {
response := &MessengerResponse{}
response.AddActivityCenterNotification(notification)
m.config.messengerSignalsHandler.MessengerResponse(response)
}There was a problem hiding this comment.
Though combine it with my next comment.
There was a problem hiding this comment.
thanks, i added and now works fine.
Signed-off-by: yqrashawn <[email protected]>
mohsen-ghafouri
force-pushed
the
feat/wallet-connect-session-notification
branch
from
d608df7
to
708ddec
Compare
mohsen-ghafouri
force-pushed
the
feat/wallet-connect-session-notification
branch
from
708ddec
to
24f56c7
Compare
igor-sirotin
requested changes
Sep 4, 2024
|
Hey @igor-sirotin, please let me know about final decision once ready and if i should apply any changes here, thanks |
|
hey @mohsen-ghafouri ! Logic:
cc @status-im/status-go-guild |
|
@mohsen-ghafouri what's the state on this one? Please let me know if you need any help with the subscriber pattern! |
|
Hey @igor-sirotin, sorry i was working on other priority task, will be in touch once i started working on this. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a new activity center notification when new wallet connect session added
mobile PR status-im/status-mobile#20905
mobile ISSUE status-im/status-mobile#20467
Important changes:
InjectedMessengerin wallet service to avoid import cycleAddWalletConnectSessionactivity_center_notificationstable