speed up tests by loading sample once #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to our test suite, resulting in a substantial reduction in build and test run times. Previously, our tests took approximately 45 minutes to complete. With the changes implemented in this PR, the test suite now completes in about 15 minutes. This represents a time savings of approximately 67%, a substantial improvement that enhances the efficiency of our development process. The reduced test run time will make it easier and more convenient for developers to run tests before committing code to the repository.
The optimization was achieved by modifying the test setup to sample 1000 records once and pass them to each test. This approach is more efficient and still allows us to thoroughly test our functions.