add schedule #317
Closed
add schedule #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AsfaMumtaz validation successful` |
d3adb5
requested changes
Jul 6, 2024
| @@ -1307,7 +1307,7 @@ cronJob: | |||
| cpu: 1 | |||
|
|
|||
| # Take backup of application namespace | |||
| backup: | |||
| schedule: | |||
There was a problem hiding this comment.
Instead of schedule we can be a little more explicit about what this is for in the value's own name.
Suggested change
| schedule: | |
| backupSchedule: |
What do you think, @AsfaMumtaz?
| ########################################################## | ||
| backup: | ||
| schedule: |
There was a problem hiding this comment.
Same suggestion as in the other thread I opened.
|
I forgot to mention one thing: this changes the interface in a way that is not backwards compatible, so it would require a major version bump. How about instead we detect whether |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.