Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Add Node.js v22 and use runner.os #294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cclauss
Copy link

@cclauss cclauss commented Aug 29, 2024

Node.js v22 will fail on GitHub Actions and elsewhere unless node-gyp==^10.2.0

GitHub Actions recommendation for detecting the operating system:

run: sudo apt-get install -y build-essential libgl1-mesa-dri libglapi-mesa
libglew-dev libglu1-mesa-dev libosmesa6
libxi-dev mesa-utils pkg-config
- run: npm ci
- run: rm package-lock.json
- run: npm install
Copy link
Author

@cclauss cclauss Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once package.json and package-lock.json have been upgraded to node-gyp==^10.2.0 then these two lines should be reverted back to - run: npm ci to align with AppVeyor.

@cclauss cclauss changed the title GitHub Actions" Add Node.js v22 and use runner.os GitHub Actions: Add Node.js v22 and use runner.os Aug 29, 2024
cclauss added a commit to cclauss/headless-gl that referenced this pull request Aug 29, 2024
A subset of
* stackgl#294 to fix macOS tests on GitHub Actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant