Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace texture id from Integer to NumberObject. #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace texture id from Integer to NumberObject. #130

wants to merge 1 commit into from

Conversation

anokta
Copy link

@anokta anokta commented Apr 25, 2018

This is to fix the reference equality checks when using three.js.

@dhritzkiv
Copy link
Member

Thanks for the submission and sorry for the delay in reviewing this.

I've caught up your branch with the latest state of the repo.

If you may, could you please describe the equality checks in three.js you were referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants