Pass request by name into methods

[gadomski]

Related Issue(s):

• This makes Configure database connections #22 less breaking.

Description:

Some downstreams, e.g. the Planetary Computer, use the request as a part of their caching mechanism. #22 has some internal calls to functions where request is passed as a positional parameter, which breaks generic caching mechanism, which fetch request from kwargs. This PR changes to make sure those internal calls pass request by name.

PR Checklist:

• pre-commit hooks pass locally
• Tests pass (run make test)
• Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
• Changes are added to the CHANGELOG.

[pjhartzell]

Are we concerned about regression? Or do we trust future devs to inspect the history and understand that there is a reason (untested) for these positional args to be passed as keyword args?

[gadomski]

Are we concerned about regression? Or do we trust future devs to inspect the history and understand that there is a reason (untested) for these positional args to be passed as keyword args?

It's a good point. We could sprinkle comments around explaining what's going on, but that feels like a bit of a rabbit hole. I think it's ok to just have the explanation in the git/github history.

[pjhartzell]

Would a test be overkill? A regression would fail the test, which would make clear that those args are keyword-ed for a reason.

[gadomski]

No a test makes sense, I'll add something that mimics what the PC is doing.

[gadomski]

Whelp, that test ended up being more involved than expected, but got it.