Merge pull request #50 from Fanevanjanahary/conf

Fix created_date in conf
stac-utils · Dec 9, 2021 · 6c2e5a1 · 6c2e5a1
2 parents 3627bdf + e2b7570
commit 6c2e5a1
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 10 deletions.
diff --git a/src/qgis_stac/conf.py b/src/qgis_stac/conf.py
@@ -65,15 +65,17 @@ def from_qgs_settings(
         :returns: Connection settings object
         :rtype: ConnectionSettings
         """
-        created_date = datetime.datetime.strptime(
-            settings.value("created_date"),
-            "%Y-%m-%dT%H:%M:%S.%fZ"
-        )
         try:
+            created_date = datetime.datetime.strptime(
+                settings.value("created_date"),
+                "%Y-%m-%dT%H:%M:%S.%fZ"
+            )
             auth_cfg = settings.value("auth_config").strip()
 
         except AttributeError:
+            created_date = datetime.datetime.now()
             auth_cfg = None
+
         return cls(
             id=uuid.UUID(identifier),
             name=settings.value("name"),

diff --git a/test/test_settings_manager.py b/test/test_settings_manager.py
@@ -81,8 +81,13 @@ def test_connection_settings(self):
                 connection_id
             )
         self.assertEqual(
-            connection,
-            stored_connection
+            connection.auth_config,
+            stored_connection.auth_config
+        )
+
+        self.assertEqual(
+            connection.created_date.replace(second=0, microsecond=0),
+            stored_connection.created_date.replace(second=0, microsecond=0)
         )
 
         # Adding a second connection, setting it a current selected
@@ -102,8 +107,13 @@ def test_connection_settings(self):
                 second_connection_id
             )
         self.assertEqual(
-            second_connection,
-            second_stored_connection
+            second_connection.auth_config,
+            second_stored_connection.auth_config
+        )
+
+        self.assertEqual(
+            second_connection.created_date.replace(second=0, microsecond=0),
+            second_stored_connection.created_date.replace(second=0, microsecond=0)
         )
         settings_manager.set_current_connection(
             second_connection_id
@@ -113,9 +123,15 @@ def test_connection_settings(self):
         self.assertTrue(settings_manager.is_current_connection(
             second_connection_id
         ))
+
+        self.assertEqual(
+            second_connection.auth_config,
+            current_connection.auth_config
+        )
+
         self.assertEqual(
-            second_connection,
-            current_connection
+            second_connection.created_date.replace(second=0, microsecond=0),
+            current_connection.created_date.replace(second=0, microsecond=0)
         )
 
         # Retrieve all the connections