dns: display error if zone domain does not match custom domain

sst · Aug 24, 2024 · 304a319 · 304a319 · rbasto1 · Sep 2, 2024
1 parent 75495a0
commit 304a319
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/platform/src/components/aws/dns.ts b/platform/src/components/aws/dns.ts
@@ -38,6 +38,7 @@ import { ComponentResourceOptions, output } from "@pulumi/pulumi";
 import { Transform, transform } from "../component";
 import { Input } from "../input";
 import { route53 } from "@pulumi/aws";
+import { VisibleError } from "../error";
 
 export interface DnsArgs {
   /**
@@ -164,7 +165,17 @@ export function dns(args: DnsArgs = {}) {
       return dnsRecord;
 
       function lookupZone() {
-        if (args.zone) return args.zone;
+        if (args.zone) {
+          return output(args.zone).apply(async (zoneId) => {
+            const zone = await route53.getZone({ zoneId });
+            if (!partial.name.replace(/\.$/, "").endsWith(zone.name)) {
+              throw new VisibleError(
+                `The DNS record "${partial.name}" cannot be created because the domain name does not match the hosted zone "${zone.name}" (${zoneId}).`,
+              );
+            }
+            return zoneId;
+          });
+        }
 
         return new HostedZoneLookup(
           `${namePrefix}${partial.type}ZoneLookup${nameSuffix}`,