Update refresh.sh to use rearguard file #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update refresh.sh to use rearguard file to properly handle timezones with negative DST offset (e.g. Europe/Dublin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update refresh.sh to use rearguard file to properly handle timezones with negative DST offset (e.g. Europe/Dublin).
The original caused timezones with negative DST (like Europe/Dublin) to have isDst set inverse of expectations for CLDR (e.g. false in summer, true in winter). This causes problems in case the isDST flag is used to get the timezone names from e.g. CLDR.
(See for example this mailchain: [https://bugs.openjdk.org/browse/JDK-8195595], and CLDR documentation: https://cldr.unicode.org/development/updating-codes/update-time-zone-data-for-zoneparser)