Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config::processLongArgument(): fix storing of unknown arguments #3913

Closed
wants to merge 1 commit into from

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 28, 2023

Description

These arguments should be stored in the unknown property. There is no values property.

Note: the read/write logic is to prevent a Indirect modification of overloaded property PHP_CodeSniffer\Config::$unknown has no effect PHP notice.

Suggested changelog entry

N/A (I don't think this bug had any impact on end-users)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

These arguments should be stored in the `unknown` property. There is no `values` property.

Note: the read/write logic is to prevent a `Indirect modification of overloaded property PHP_CodeSniffer\Config::$unknown has no effect` PHP notice.
@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 2, 2023

Closing as replaced by PHPCSStandards/PHP_CodeSniffer#97

@jrfnl jrfnl closed this Dec 2, 2023
@jrfnl jrfnl deleted the feature/config-bugfix branch December 2, 2023 02:39
@jrfnl jrfnl added this to the 3.8.0 milestone Dec 8, 2023
@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2023

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant