Generic/OpeningFunctionBraceKernighanRitchie: fix error position

[jrfnl]

Description

The SpaceBeforeBrace error code is about the space before the scope opener, but was being thrown on the parenthesis closer preceding it, which could be confusing when there is a type declaration between the two.

Fixed now.

I haven't added a test as no meaningful test can be added as the error "column" is not part of the test logic.

To see the issue run the following command over the below code snippet:

phpcs test.php --standard=Generic --sniffs=Generic.Functions.OpeningFunctionBraceKernighanRitchie --report=code

function foo( $param_a, $param_b ): Type       {}
//                       The space here   ^   was originally flagged on the close parens, not the open brace.

Suggested changelog entry

N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

[fredden]

It took me a little longer to test this proposed change as the sniff skips over this section of code for empty functions. Adding a statement to the example test.php file provided allowed me to test properly. I have now verified both the claim and the fix.

[jrfnl]

Closing as replaced by PHPCSStandards/PHP_CodeSniffer#82