Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 | PSR1/SideEffects: allow for readonly classes #3728

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Standards/PSR1/Sniffs/Files/SideEffectsSniff.php
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ private function searchForConflict($phpcsFile, $start, $end, $tokens)
}

// Ignore function/class prefixes.
if (isset(Tokens::$methodPrefixes[$tokens[$i]['code']]) === true) {
if (isset(Tokens::$methodPrefixes[$tokens[$i]['code']]) === true
|| $tokens[$i]['code'] === T_READONLY
) {
continue;
}

Expand Down
8 changes: 8 additions & 0 deletions src/Standards/PSR1/Tests/Files/SideEffectsUnitTest.1.inc
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,12 @@ namespace {

defined('APP_BASE_URL') or define('APP_BASE_URL', '/');

readonly class Foo {
public function __construct(
private string $foo,
private string $bar,
) {
}
}

?>