Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion support for non default schema #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aokiji
Copy link

@aokiji aokiji commented Apr 6, 2024

As seen in #99 and #121 there is lack of support for completion when working with other schemas/databases other than the default schema/database. So this in the initial effort to fix this issue bringing support for:

  • table completion when given the schema
  • table description for table in any schema
  • column completion when given table in any schema
  • column completion for tables in any schema referenced in the join clause

Test were added so that the new features/changes are covered

non default schema tables where not considered as candidates for
completion
@mattn
Copy link
Member

mattn commented Apr 14, 2024

Looks good.

@v2okimochi
Copy link

Any updates on this? I'd like to use it awesome feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants