Feature filter unused structs in models #2336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! As you know this has been a feature request for awhile. I'm not sure how Kyle wants to handle this but at the very least, in order to merge, we would need to address the failing test and write at least one new test that covers usage of this new config option. |
|
There are a few issues with this implementation, so I took a crack at one of my own in #2369. It should behave similarly to this one, but covers a few more edge cases. I'll close this PR and we can continue discussion on the new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config option
emit_filter_unused_models.If true, add only used by queries models to models.go.
#710