Optimize wildcard pattern matching in initCounters() #33621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR refactors the
initCounters()
method inPatternInfo
to enhance code readability, improve performance, and increase accuracy in wildcard counting. The primary focus of this change is to optimize the handling of single and double wildcard patterns.Changes:
.*
pattern detection: Improved the accuracy of single wildcard counting by refining the logic that detects.*
patterns.substring()
withcharAt()
: Direct character comparisons are now used instead ofsubstring()
to reduce unnecessary object creation and improve performance.*
), improving overall reliability.Impact:
substring()
calls and unnecessary object creation leads to a more efficient method, especially for longer patterns or frequent invocations.substring()
, the potential for memory-related issues is reduced, particularly when dealing with large string patterns.The changes maintain backwards compatibility with the existing behavior, and no functionality has been altered.
Please review the changes and provide feedback!