chore(dependency): add explicit dependency of jackson-module-jaxb-annotations while upgrading spring boot 2.6.x #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otations while upgrading spring boot 2.6.x While upgrading spring boot 2.6.15, encounter below errors in igor-web module during build: ``` > Task :igor-web:compileGroovy startup failed: /igor/igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/JenkinsConfig.groovy: 22: unable to resolve class com.fasterxml.jackson.module.jaxb.JaxbAnnotationModule @ line 22, column 1. import com.fasterxml.jackson.module.jaxb.JaxbAnnotationModule ^ 1 error > Task :igor-web:compileGroovy FAILED ``` To fix these issues, adding explicit dependency of jackson-module-jaxb-annotations in igor-web.gradle. Since jackson-module-jaxb-annotations is a transitive dependency of [spring boot](https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.6.15/spring-boot-dependencies-2.6.15.pom) both 2.5.x and 2.6.x, pinning the dependency is not required.
dbyron-sf
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading spring boot 2.6.15, encounter below errors in igor-web module during build:
To fix this issue, adding explicit dependency of jackson-module-jaxb-annotations in igor-web.gradle. Since jackson-module-jaxb-annotations is a transitive dependency of spring boot both 2.5.x and 2.6.x, pinning the dependency is not required.